To-do List
-
Should be working now.
The emails, I was aware of (original issue here), tried to make a quick hack last night, didn't have time to actual test how it worked. I found a better solution.For now I'm using something called Mailgun to send mails, you've got to manually confirm participation on those e-mails. I sent that confirmation email a few minutes.
-
Above you can see me testing to make sure the subscription button functionality works with my own account on this thread. It looks like there is some trigger that's not happening for:
if you contribute to the thread
a subscription is created for you automatically
endRegardless, the button says "unsubscribe" on the thread now, for me, because I created it--and in this situation no subscription record in the db is necessary because the thread already belongs to me. However, should we add this above functionality--posting means a subscription?
-
Quotes is a big deal for me. Without that, there goes how I organize how and what I reply to.
Actually, quotes were showing up after clicking the submit button. I just added a style to the .css so you can preview them too. That still needs to be tweaked. It does weird stuff on mobile and needs a newline so you can reply easily.
There's a second 'Subscribe/Unsubscribe' button at the bottom now. That will show alongside pagination when we get that working. The page also auto-scrolls on PC now but it would be better to auto-scroll to the anchor tag of the most recent post.
didn't have time to actual test how it worked. I found a better solution.
It's working now. I'm getting emails. Might be a good one to submit a PR for.
should we add this above functionality--posting means a subscription?
I would put that as a check box under user settings (default = checked)
-
needs a newline so you can reply easily
Actually, if you hit enter once, it goes to a new line in the quote but, if you hit enter a second time, it jumps down to the next line outside the quote. However, if you hold SHIFT + ENTER, it will continue to add new lines within the quote.
testing code here
-
The first time clicking on the topic, the thread shows the oldest post at the top and does not take you to the bottom. If, however, you hit the back button and then try again, it takes you to the bottom and most recent post.
I bring up email first because when you get an e-mail it comes with a "reply" link that links you directly to the last post in the thread right above the composition box. Additionally, maybe we could just add a 'skip to the top' button at the bottom and a 'skip to the bottom' button at the top? Where the buttons go at the bottom there it may also be nice to have some other tools later, like moderation, voting, and thread related modal pop-ups with settings.
-
The first time clicking on the topic, the thread shows the oldest post at the top and does not take you to the bottom. If, however, you hit the back button and then try again, it takes you to the bottom and most recent post.
Yeah, sometimes it takes you to the middle of the page too. It's probably an async thing (scroll starts before all posts are loaded) and probably fixed now. But, yeah it would definitely be better to scroll to the top of the most recent post. I'll try to add anchor tags with post IDs or something.
Where the buttons go at the bottom there it may also be nice to have some other tools later, like moderation, voting, and thread related modal pop-ups with settings.
and pagination. I saw something about it in the code but not a variable that says how many posts will trigger it. Maybe it's like 50 or 100. We can do it!
There's your 'top' button. I made the subscribe button green. The unsubscribe button should be red outline...later.
-
Noice. Yeah, agree on the unsubscribe button, that's much more clear UI wise. Can you group the buttons at the bottom together?
Pagination is easy, can be set up pretty quickly, I just haven't had time yet. Sorry busy working on work stuff. I'll get there, heh.
-
Fora is now inside of the-flying-dutchmen repo. This will make everything A LOT easier.
I see you added the buttons there on the bottom, looks great. Tonight, if I can find time, I want to move to sendgrid so none of this email verification stuff is required.
-
Seems to be working and I'm sure this will allow me to get more done if I can wrap my head around the hierarchy - like what's pointing to what? /app/views/layouts has 4 files that I know are being used (that's what I've been editing). But now there's fora/app/views/fora that has all the forum and post views and fora.html.erb is duped (presumably unused) in fora/app/views/layouts. Can we consolidate all the views and assets?
-
Can we consolidate all the views and assets?
We should delete the app/views/layouts/fora.html.erb and keep the whole forum in the fora folder. It has it's own routing engine, so it needs to be totally separate. I tried to just incorporate the views and stuff, but it wouldn't load the libraries. I have to research why. But I suspect there's gonna have to be some rather technical re-routing/referencing going on--this was the best I could do in the hour I had.
The hierarchy for the forum is:Â
app/views/layouts/application.html.erb (holds everything, has the TFD header)
   fora/app/views/layouts/fora.html.erb (forum points here, it's own entity, holds the left side navigation)
      /fora/app/views/fora/forum_posts.html.erb (and forum_threads.html.erb load here on the right side)Damn this thread is getting loooooooong.
Yeah I think that needs to be next on the to-do list, eh.
-
Happy Halloween!
Pagination added, though when you click on a thread it still goes to the first page by default. Should I change it so it goes to the last page, and anchors to the last post by default? That'd be a very quick fix.
What's next on the list. Josh, I know you were wondering about moving all the stuff that's in 'fora' to 'app/fora' and just turning "fora" into a forum subsection of the app. I started working on that but it's a pretty big change, going to have to change all the routing and links and all kinds of stuff--but it is do-able. Also mention of desire for usenames and avatars, maybe I should add that functionality next?
-
Should I change it so it goes to the last page, and anchors to the last post by default?
Notifications of new comments should definitely do that but clicking on the link to the post in the sidebar should go to the original post and there should be a 'See most recent comment' button at the top (rather than a button that just goes to the bottom of the page because that would just be a random point in the thread what with pagination and such.)
I know you were wondering about moving all the stuff that's in 'fora' to 'app/fora' and just turning "fora" into a forum subsection of the app.
It already appears to be a subsection of the app as well as the app itself. It just seems strange to have a few of the views that are specific to the forum broken out into another views folder.
I guess it just depends on how 'app' is defined. Is the app the website that includes the forum, shop, muli-player gaming platform etc.? If so, I say put all the views related to the forum into the fora folder to compartmentalize it. If you think the forum and the node.js gaming platform I'm working on should each be self contained entities linked to from the outside, I say pull everything out of the fora folder, integrate it into the main app and make fora that entire app.
I opt for the latter. Fora should be its own app. The gaming platform should be its own app. The shop should be its own app. And 'the-flying-dutchmen' repo should contain all the folders for those apps. I don't know if heroku will like that though. What do you think?
-
Really like the newly styled quote boxes. Would be nice to have an autosave thing, I may try to get on that at some point as well.
Agreed about the "see most recent" button and the first post of the thread being the post at the top. I like the links at the bottom and the "TFD," as well.
As for the, how is "app" defined--I also agree, which is one of the merits of keeping it all in its separate folder. If we wanted to run it on it's own dyno in the future, it could be done very quickly. I'm went ahead and moved the forum main page here (the other page was overwriting it, so there was to copies of a file with the same purpose).
Also a note about JS, for testing it's fine to put JS in the main template (speedier, and you don't have to recompile every time you reload a page). But in production, I copied the js into the webpacker file for fora, referred here, so that webpacker can compile everything. Though, I suppose it should really be in the fora folder...Hmmm.
-
In addition to those issues, if I want to quote portions of someone else's post, there's no way to tell the forum/system where the quote ends. I have to start writing a reply first, and THEN go and copy and paste what I want to quote. Otherwise, if I do that first, my reply cannot escape being included in the quote.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login